Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoMaker trodes fixes and resume from fail #1174

Merged
merged 10 commits into from
Nov 7, 2024
Merged

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Oct 31, 2024

Description

  1. Adds features to resume from fail
  2. Addresses failing test on TrodesPosVideo to ensure matplotlib compatibility, including headless for testing

Checklist:

  • no. This PR should be accompanied by a release: (yes/no/unsure)
  • n/a If release, I have updated the CITATION.cff
  • no. This PR makes edits to table definitions: (yes/no)
  • n/a If table edits, I have included an alter snippet for release notes.
  • yes. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • n/a I have added/edited docs/notebooks to reflect the changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1 CBroz1 marked this pull request as ready for review November 6, 2024 21:17
@@ -31,6 +31,8 @@
"#ffe91a",
]

matplotlib.use("Agg") # Use non-interactive backend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this will affect the context after importing? Will the user have to reset this to see plots?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - My latest commit tracks the previous backend and reverts on completion

@edeno edeno merged commit 0c5a903 into LorenFrankLab:master Nov 7, 2024
16 checks passed
@CBroz1 CBroz1 deleted the fdv branch February 10, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants