Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge table efficiency #1017

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Merge table efficiency #1017

merged 7 commits into from
Jul 9, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Jul 2, 2024

Description

Changes to help speed up fetching nwb data through merge tables

  • allow Merge.fetch_nwb to work with a restriction containing multiple entries and sources
  • pre-check dependencies loaded to in _ensure_dependencies_loaded
    • Avoid the overhead of the load call
  • avoid redundant calls to merge_get_parent in merge_restrict_class
  • refactor to single fetch_nwb call in SortedSpikesGroup.fetch_spike_data
    • avoids repeatedly running the merge table restriction process to find source tables

Checklist:

  • no This PR should be accompanied by a release: (yes/no/unsure)
  • n/a If release, I have updated the CITATION.cff
  • no This PR makes edits to table definitions: (yes/no)
  • n/a If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • n/a I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from CBroz1 July 2, 2024 19:23
@samuelbray32 samuelbray32 marked this pull request as ready for review July 2, 2024 19:25
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor request to rename a variable - otherwise good to go

@edeno edeno merged commit 31ff1cc into master Jul 9, 2024
3 checks passed
@edeno edeno deleted the merge_table_efficiency branch July 9, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants