Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fetch_nwb errors #732

Closed
edeno opened this issue Dec 22, 2023 · 1 comment · Fixed by #734
Closed

Merge fetch_nwb errors #732

edeno opened this issue Dec 22, 2023 · 1 comment · Fixed by #734
Assignees
Labels
bug Something isn't working

Comments

@edeno
Copy link
Collaborator

edeno commented Dec 22, 2023

Describe the bug
Merge fetch_nwb does not work. Results in a property error.

The culprit is PR #730
When I reverted this line:

(cls.analysis_nwbfile, "analysis_file_abs_path"),
from cls.analysis_nwbfile to AnalysisNwbfile it worked again.

To Reproduce
Steps to reproduce the behavior:
Run fetch_nwb on a merge table

@edeno edeno changed the title Merge fetch_nwb Merge fetch_nwb errors Dec 22, 2023
@edeno edeno added the bug Something isn't working label Dec 22, 2023
@CBroz1
Copy link
Member

CBroz1 commented Dec 22, 2023

The property is needed to avoid circular import on startup, but it needs to be run on the class instance, not the class itself

(cls.analysis_nwbfile, "analysis_file_abs_path"), -> (cls().analysis_nwbfile, "analysis_file_abs_path"),

CBroz1 added a commit to CBroz1/spyglass that referenced this issue Dec 22, 2023
@CBroz1 CBroz1 linked a pull request Dec 22, 2023 that will close this issue
4 tasks
edeno pushed a commit that referenced this issue Dec 22, 2023
* #732

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants