Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes issue #312 #313

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Closes issue #312 #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0b197e
Closes issue #312
mattloose Oct 28, 2023
3973ba7
Changed default for unblock_duration to value in _cli_args
Adoni5 Nov 6, 2023
8dfcae3
Update changelog
Adoni5 Nov 6, 2023
b878d43
GOD damn IDE just leave markdown numbered lists alone
Adoni5 Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ And for our Awesome Logo please checkout out [@tim_bassford](https://twitter.com
<!-- start-changelog -->
# Changelog
## Unreleased changes
None currently.
1. Change the default `unblock_duration` on the `Analysis` class to use `DEFAULT_UNBLOCK` value defined in `_cli_args.py`. Change type on the Argparser for `--unblock-duration` to float. (#313)
## 2023.1.1
1. Fix Readme Logo link 🥳 (#296)
1. Fix bug where we had accidentally started requiring barcoded TOMLs to specify a region. Thanks to @jamesemery for catching this. (#299)
Expand Down
2 changes: 1 addition & 1 deletion src/readfish/_cli_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"--unblock-duration",
dict(
metavar="UNBLOCK-DURATION",
type=int,
type=float,
help="Time, in seconds, to apply unblock voltage (default: {})".format(
DEFAULT_UNBLOCK
),
Expand Down
4 changes: 2 additions & 2 deletions src/readfish/entry_points/targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
from minknow_api import protocol_service

# Library
from readfish._cli_args import DEVICE_BASE_ARGS
from readfish._cli_args import DEVICE_BASE_ARGS, DEFAULT_UNBLOCK
from readfish._read_until_client import RUClient
from readfish._config import Action, Conf, make_decision, _Condition
from readfish._statistics import ReadfishStatistics
Expand Down Expand Up @@ -148,7 +148,7 @@ def __init__(
logger: logging.Logger,
debug_log: bool,
throttle: float = 0.1,
unblock_duration: float = 0.5,
unblock_duration: float = DEFAULT_UNBLOCK,
dry_run: bool = False,
toml: str = "a.toml",
):
Expand Down