Merge pull request #170 from Loopring/response-to-audit

response to Berkeley audit
LoopringSecondary · Nov 23, 2017 · 888887e · 888887e
2 parents d9e8b6e + 9141d49
commit 888887e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/contracts/RinghashRegistry.sol b/contracts/RinghashRegistry.sol
@@ -97,7 +97,7 @@ contract RinghashRegistry {
         bytes32[]   rList,
         bytes32[]   sList
         )
-        public
+        private
         pure
         returns (bytes32)
     {
@@ -147,6 +147,7 @@ contract RinghashRegistry {
         view
         returns (bool)
     {
+        require(ringminer != 0x0);
         var submission = submissions[ringhash];
         address miner = submission.ringminer;
         return (

diff --git a/contracts/TokenRegistry.sol b/contracts/TokenRegistry.sol
@@ -92,7 +92,7 @@ contract TokenRegistry is Claimable {
 
     function getAddressBySymbol(string symbol)
         external
-        constant
+        view
         returns (address)
     {
         return tokenSymbolMap[symbol];

diff --git a/contracts/TokenTransferDelegate.sol b/contracts/TokenTransferDelegate.sol
@@ -54,9 +54,7 @@ contract TokenTransferDelegate is Claimable {
     ////////////////////////////////////////////////////////////////////////////
 
     modifier onlyAuthorized() {
-        if (!isAddressAuthorized(msg.sender)) {
-            revert();
-        }
+        require(addressInfos[msg.sender].authorized);
         _;
     }