Do not display stale glucose data #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this perhaps be addressed through a new |
|
I would follow @diggabyte solution of adding an icon. But I would also let the loop implementation look a bit like Nightscout's implementation. Nightscout has a striketrhough and uses grey font color. For example it looks like: |
|
If you (or anyone else) rebases this change and submits before I get to it, I can take a look at it; this is a needed change. |
|
@ps2 are you fine with blanking it out? Or should we do an icon or text treatment to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the UI sometimes keeps display the last Glucose value, which can be in the best case confusing, in the worst case dangerous. Blank it out if the data is older than 15 minutes.