Fix tty:true containers. Add GHA push workflow. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the examples invoke nbb from the node_modules directory and specifying a classpath and main function, use the dcmon wrapper which constructs the equivalent command line.
For containers that have an attached TTY (Config.Tty: true), the format of the stream data is different and was breaking the log stream method we were using. For non-TTY containers, the log stream send chunks with an 8 byte frame header that specifies the type of chunk buffer (stdout or stderr) and the chunk length/size. The dockerode modem.demuxStream method is used to split the chunks into seperate stdout and stderr streams. For TTY enabled containers, the chunks have no framing and are just raw log chunk buffers. Using the same method with TTY streams causes the demuxStream function to effectively wait forever because the length of the first "frame" tends to be very large (whatever random 4 bytes of ASCII characters are sent at the start of the log). To fix this we check the inspected container data for the Config.TTY property and if it's set we just pipe the log stream from the container to our output stream that we use for scanning.
kanaka
force-pushed
the
fix-tty-containers
branch
3 times, most recently
from
8f331bc to
51647c6
Compare
jonsmock
reviewed
Apr 15, 2024
.github/workflows/push.yml
Outdated
| on: | ||
| push: {} | ||
| pull_request: | ||
| branches: [ master ] |
jonsmock
approved these changes
Apr 15, 2024
On GHA hosted runners, pinging 8.8.8.8 does not seem to work.
kanaka
force-pushed
the
fix-tty-containers
branch
from
51647c6 to
3ad81ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.