Add compat methods for ByteArrayOutputStream and InputStream #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LossyDragon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing a project on an Android device (Google Pixel 3 XL) running Android 12 (SP1A.210812.016.C1) and caught ByteArrayOutputStream#toString() throwing NoSuchMethodError with JavaSteam and the project compiled to JDK11.
Lowering the bytecode to 1.8 on the project to let desugaring take over had no effect.
Android 12 should support Java 11, but something may have not been implemented on this device to be supported.
See https://developer.android.com/build/jdks#compileSdk
This PR replaced baos.toString() to the String alternative, which works fine now.
Edit:
Also fixes compatibility issues with InputStream.readNBytes()
Closes #307
Checklist