Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-606: Fixing new C# 11 analyzer violations #26

Merged
merged 2 commits into from
Jun 6, 2023
Merged

OSOE-606: Fixing new C# 11 analyzer violations #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0393f
Fixing "CA1852 Type 'ConfigurableCertificateValidatingHttpClientHandl…
Piedone Jun 4, 2023
bdb2e77
Fixing more "CA1852 Type '...' can be sealed because it has no subtyp…
Piedone Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Apis/Context/AuthenticationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// Copied from AuthenticationContext.cs in OrchardCore.Tests.Apis.Context with minor modifications.
namespace Lombiq.SetupExtensions.Apis.Context;

internal class PermissionContextAuthorizationHandler : AuthorizationHandler<PermissionRequirement>
internal sealed class PermissionContextAuthorizationHandler : AuthorizationHandler<PermissionRequirement>
{
private readonly PermissionsContext _permissionsContext;

Expand Down Expand Up @@ -56,7 +56,7 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte
}
}

internal class AlwaysLoggedInApiAuthenticationHandler : AuthenticationHandler<ApiAuthorizationOptions>
internal sealed class AlwaysLoggedInApiAuthenticationHandler : AuthenticationHandler<ApiAuthorizationOptions>
{
public AlwaysLoggedInApiAuthenticationHandler(
IOptionsMonitor<ApiAuthorizationOptions> options,
Expand All @@ -72,14 +72,14 @@ protected override Task<AuthenticateResult> HandleAuthenticateAsync() =>
new System.Security.Claims.ClaimsPrincipal(new AlwaysLoggedInIdentity()), "Api")));
}

internal class PermissionsContext
internal sealed class PermissionsContext
{
public IEnumerable<Permission> AuthorizedPermissions { get; set; } = Enumerable.Empty<Permission>();

public bool UsePermissionsContext { get; set; }
}

internal class AlwaysLoggedInIdentity : IIdentity
internal sealed class AlwaysLoggedInIdentity : IIdentity
{
public string AuthenticationType => "Always Authenticated";

Expand Down