Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-588: Upgrade to 1.5.0 #35

Merged
merged 15 commits into from
Apr 2, 2023
Merged

OSOE-588: Upgrade to 1.5.0 #35

merged 15 commits into from
Apr 2, 2023

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Mar 9, 2023 •
edited by jira bot
Loading

@jtkech jtkech mentioned this pull request Mar 29, 2023
Closed
@Piedone
Copy link
Member

Piedone commented Mar 30, 2023

We'd need this merged before OC 1.6 is released and we start upgrading to that. When do you think you can finish here?

@jtkech
Copy link
Member Author

jtkech commented Mar 30, 2023

For me it was ready but I will look at #38 this week end.

@Piedone
Copy link
Member

Piedone commented Mar 30, 2023

Thanks!

@Piedone
Copy link
Member

Piedone commented Mar 30, 2023

Let me know here when you're ready.

@jtkech
Copy link
Member Author

jtkech commented Mar 31, 2023

@Piedone

Okay, I did some last updates and retried it under https://github.com/Smithsonian/CFCH-folkwaysCore/pull/92 to migrate Folkways to OC 1.5.0, seems to be working. So I think it is ready to be reviewed.

@jtkech jtkech requested a review from Piedone March 31, 2023 21:30
@jtkech
Copy link
Member Author

jtkech commented Mar 31, 2023

@Piedone

Okay updated.

Why did you remove pnpm-lock from .gitignore?

As it is generated on build

@Piedone
Copy link
Member

Piedone commented Apr 2, 2023

Lock files should be stored in the repos. They're regenerated but their purpose is to lock floating NPM package versions to specific ones, and if we don't store them in the repo then different developers may get different versions, which can cause different behavior.

@Piedone Piedone merged commit 98e9d29 into dev Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtkech @Piedone