Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-464: Fixing that .NET build errors didn't fail the GHA build #282

Merged
merged 9 commits into from
Nov 20, 2022

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Nov 20, 2022

@github-actions
Copy link

github-actions bot commented Nov 20, 2022

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (2)

ard
ctionary

Previously acknowledged words that are now absent abcdef chromedriver editorconfig enableextensions eur favicon Hsl https iis itemprop json labelledby linq localhost lockfile markdownlint mscorlib mvc myapp ndproj NPM pnpm pragma publishsettings Reks Rekt RSPEC setlocal SFCs sourcemaps sql uri wpf yaml yml
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Lombiq/Open-Source-Orchard-Core-Extensions.git repository
on the dev branch (ℹ️ how do I use this?):

update_files() {
mkdir -p '.github/actions/spelling/'
cp -i -R $(
cd $(mktemp -d)
git clone --depth 1 --no-tags https://github.com/Lombiq/GitHub-Actions --branch dev . > /dev/null 2> /dev/null
cd '.github/actions/spelling/'; pwd
)/* '.github/actions/spelling/'
git add '.github/actions/spelling/'
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/Lombiq/Open-Source-Orchard-Core-Extensions/issues/comments/1321256726" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" | tr -d "\\r" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u
Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (226) from .github/actions/spelling/expect.txt and unrecognized words (2)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 23
cspell:software-terms/src/software-terms.txt 1237 21
cspell:node/node.txt 1768 14
cspell:python/src/python/python-lib.txt 3873 8
cspell:php/php.txt 2597 7

Consider adding them using (in .github/workflows/build-and-test.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:software-terms/src/software-terms.txt
          cspell:node/node.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

@Piedone Piedone merged commit 7562432 into dev Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant