Issue #151: impl std::io::Write for u8-based TinyVecs #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Normally a feature could be documented in the crate docs of lib.rs. Unfortunately there's not a good "official" way to doc features at this time. |
Lokathor
approved these changes
Sep 24, 2021
|
There is https://doc.rust-lang.org/rustdoc/unstable-features.html#doccfg-recording-what-platforms-or-features-are-required-for-code-to-be-present which is only available on rustdoc nightly, but is already enabled on docs.rs |
|
If you want I could merge it now and just put in some docs before i publish it later today. |
Sure, that's obviously fine with me. ;) Much appreciated! |
|
released as 1.5.0! |
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.rust.crates.tinyvec
that referenced
this pull request
Jan 24, 2023
Instead of force-patching lib.rs, remove the ![no_std] attribute through the upstream feature 'std', which was added in 1.5.0 [1]. Update Android.bp by running cargo2android.py. [1]: Lokathor/tinyvec#152 Test: TH Change-Id: Idea781c1ad3f8a4b1ebec7c651b7081feff581ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
std::io::Writefor u8-based TinyVecs. As such, it also introduces a new feature flag namedstd, which is off by default.I didn't really see anywhere interesting to document that this exists, so any pointers there would be cool.
This closes issue #151