Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prepare script #65

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Add prepare script #65

merged 1 commit into from
Jan 5, 2023

Conversation

shekharkhedekar
Copy link
Contributor

No description provided.

@shekharkhedekar
Copy link
Contributor Author

@Logerfo this attempts to fix #57. The docs mention that a package-lock.json should be included.

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Jan 5, 2023
Logerfo
Logerfo reviewed Jan 5, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@shekharkhedekar shekharkhedekar marked this pull request as draft January 5, 2023 15:30
@shekharkhedekar
Copy link
Contributor Author

Still trying to get this to work without any luck...seems to be specific to js-yaml

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 5, 2023
Logerfo
Logerfo reviewed Jan 5, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jan 5, 2023
@Logerfo Logerfo linked an issue Jan 5, 2023 that may be closed by this pull request
Cannot find module js-yaml. #57
Closed
@Logerfo Logerfo added the bug Something isn't working label Jan 5, 2023
@shekharkhedekar
Copy link
Contributor Author

I stand corrected - if I reorder imports, it can't find @actions/core. Something is happening that is failing npm install. Digging more.

@shekharkhedekar shekharkhedekar changed the title Remove package-lock.json from .gitignore Add prepare script Jan 5, 2023
@shekharkhedekar shekharkhedekar marked this pull request as ready for review January 5, 2023 16:32
@shekharkhedekar
Copy link
Contributor Author

@Logerfo Had to do a couple of things to get it to work:

Tested on this PR.

Please take a look. Thanks!

@Logerfo
Copy link
Owner

Logerfo commented Jan 5, 2023

@shekharkhedekar do you mind sanitizing the PR so the diff can be minimum? Seems like changes to main.js are not needed.
Also, the commit on your test PR seems empty. The bot is not supposed to push empty changes. Is that correct?

@shekharkhedekar
Copy link
Contributor Author

@shekharkhedekar do you mind sanitizing the PR so the diff can be minimum? Seems like changes to main.js are not needed. Also, the commit on your test PR seems empty. The bot is not supposed to push empty changes. Is that correct?

@Logerfo cleaned up main.js - there was one change. As far as the empty commit, I see that as well - not sure why that's happening.

@Logerfo Logerfo merged commit c8b9afb into Logerfo:master Jan 5, 2023
@Logerfo
Copy link
Owner

Logerfo commented Jan 5, 2023

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Logerfo Logerfo Logerfo left review comments

Assignees
No one assigned
Labels
bug Something isn't working size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find module js-yaml.
2 participants
@shekharkhedekar @Logerfo