umd and es targets instead of import source

[thiamsantos]

That should close #233.

But needs testing to prevent #229 and #231 to happen again.

[imevro]

Can you test?

[thiamsantos]

Sure. Right now I can't, but I will do it when I get home.

[thiamsantos]

Sorry for the delay, I will try to test it in this weekend.

[thiamsantos]

I tested with rollup and webpack, and everything seems to work.

Dependencies used:

{
  "babel-core": "^6.24.1",
  "babel-loader": "^7.0.0",
  "babel-plugin-external-helpers": "^6.22.0",
  "babel-preset-env": "^1.4.0",
  "rollup": "^0.41.6",
  "rollup-plugin-babel": "^2.7.1",
  "rollup-plugin-commonjs": "^8.0.2",
  "rollup-plugin-node-resolve": "^3.0.0",
  "webpack": "^2.4.1"
}

webpack.config.js

var path = require('path')

module.exports = {
  entry: './app/main.js',
  output: {
    filename: 'bundle.js',
    path: path.resolve(__dirname, 'public')
  },
  module: {
    rules: [
      {
        test: /\.js$/,
        exclude: /node_modules/,
        use: {
          loader: 'babel-loader',
          options: {
            presets: ['env']
          }
        }
      }
    ]
  }
}

rollup.config.js

import commonjs from 'rollup-plugin-commonjs'
import nodeResolve from 'rollup-plugin-node-resolve'
import babel from 'rollup-plugin-babel'

export default {
  entry: 'app/main.js',
  format: 'iife',
  plugins: [
    babel({
      exclude: 'node_modules/**',
      presets: [
        [
          'env',
          {
            modules: false
          }
        ]
      ],
      plugins: [
        'external-helpers'
      ]
    }),
    nodeResolve({
      jsnext: true,
      module: true,
      main: true,
      browser: true
    }),
    commonjs()
  ],
  dest: 'public/bundle.js'
}

[maxrbaldwin]

Still getting the Module not found: Error: Can't resolve 'redux-logger' error. This seems to be the fix. Will this get merged any time soon? @thiamsantos @evgenyrodionov

[imevro]

Can you bring back src folder? I think some users can rely on this and I don't see reasons break it.

[thiamsantos]

Sure

[thiamsantos]

Done

[codecov-io]

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #234   +/-   ##
=====================================
  Coverage      82%    82%           
=====================================
  Files           5      5           
  Lines         150    150           
=====================================
  Hits          123    123           
  Misses         27     27

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721e17...507611b. Read the comment docs.

[thiamsantos]

Any thoughts @evgenyrodionov?

[itsjoekent]

Any updates on this being merged?

[thiamsantos]

Any updates on this @evgenyrodionov ?

[grushetsky]

@thiamsantos, could you, please, resolve conflicts by rebasing to the latest master?

[thiamsantos]

@grushetsky conflicts resolved.

[grushetsky]

@evgenyrodionov, let's merge this one, do you mind?

[imevro]

➕

[gregorym]

Has this been released in 3.0.6? I'm still seeing this issue with version 3.0.6

[adipascu]

The fix is not currently released.

…

On Wed, Aug 29, 2018, 21:42 Gregory ***@***.***> wrote: Has this been released in 3.0.6? I'm still seeing this issue with version 3.0.6 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#234 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABc2qQsrF5qtjwVs9aG5h70l1wPmTeOPks5uVuCvgaJpZM4NffGb> .

[gregorym]

@evgenyrodionov Is something preventing a new release (3.0.7)? This has been merged months ago.

[d4rky-pl]

Bump