Added airbnb eslint config #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 68.14% 68.38% +0.23%
==========================================
Files 5 5
Lines 135 136 +1
==========================================
+ Hits 92 93 +1
Misses 43 43
Continue to review full report at Codecov.
|
imevro
requested changes
Apr 5, 2017
.eslintrc
Outdated
| @@ -1,3 +1,11 @@ | |||
| { | |||
| "extends": "@dtrussia/eslint-config-dtrussia" | |||
| "extends": "airbnb", | |||
| "globals": { | |||
There was a problem hiding this comment.
You can use env setting instead of list of global functions
http://eslint.org/docs/user-guide/configuring#specifying-environments
package.json
Outdated
| @@ -55,7 +55,6 @@ | |||
| "@dtrussia/eslint-config-dtrussia": "2.2.1", | |||
There was a problem hiding this comment.
If we don't use it anymore, it needs to be removed
src/core.js
Outdated
| } | ||
| }); | ||
| } | ||
| export { |
There was a problem hiding this comment.
Why, if we use export default?
|
Thanks for your suggestions @evgenyrodionov , should be ok now ;) |
imevro
approved these changes
Apr 6, 2017
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will make another pull request for tests