Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore color formatting with custom titleFormatter #216

Merged
merged 2 commits into from
Mar 30, 2017

Conversation

jdelman
Copy link
Contributor

@jdelman jdelman commented Mar 30, 2017

fixes #215

@codecov-io
Copy link

Codecov Report

Merging #216 into master will increase coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   67.91%   68.14%   +0.23%     
==========================================
  Files           5        5              
  Lines         134      135       +1     
==========================================
+ Hits           91       92       +1     
  Misses         43       43
Impacted Files Coverage Δ
src/core.js 78.33% <66.66%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993c896...a04a28a. Read the comment docs.

@imevro imevro merged commit 399dd35 into LogRocket:master Mar 30, 2017
@imevro
Copy link
Collaborator

imevro commented Mar 30, 2017

thx

@cooperka
Copy link

I actually quite liked the new colors! I simply added %c a couple times in my custom titleFormatter string and it colored my output properly.

@evgenyrodionov is there any way to keep the colors AND use a custom formatter now? After this PR my colors are broken again (3.0.1). Otherwise I'll make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using titleFormatter breaks color formatting in Chrome
4 participants