Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade spring Boot to 3.0 #326

Closed
2 tasks done
credmond-git opened this issue Dec 2, 2022 · 12 comments
Closed
2 tasks done

Upgrade spring Boot to 3.0 #326

credmond-git opened this issue Dec 2, 2022 · 12 comments
Labels
dependency-upgrade Auto-generates notes
Milestone

Comments

@credmond-git
Copy link

credmond-git commented Dec 2, 2022

@jvmlet
Copy link
Collaborator

jvmlet commented Dec 2, 2022

Have you tried the latest with spring boot 3.0 app? Which error do you get?

@credmond-git
Copy link
Author

For a very basic example using spring boot 3.0 and io.github.lognet:grpc-spring-boot-starter:4.9.0 i am did not get any issues.
Would you generally consider it safe to use this project with spring boot 3.0?

@jvmlet
Copy link
Collaborator

jvmlet commented Dec 3, 2022

Because looking at release notes and migration guide I don't see something that might prevent using starter developed with 2.7.x API. Also, it's not even sound logical from spring team to drop support of all starters developed so far just because there is new 3.0 runtime and API.
Anyway, I'll run all tests with 3.0 app just to make sure and update release notes with supported SB sversions.

@bschlief
Copy link

bschlief commented Dec 4, 2022

FWIW, I attempted to update my 2.7.x project to 3.0 this week and found that I could get the service to start, but that the GrpcServer didn't appear to start.

I didn't see any errors, it just seemed like the server didn't start. I didn't notice any errors in the logs, but I'll check again tomorrow and post here.

I'm wondering if this issue/workaround in a separate spring boot starter for grpc project might be related? https://github.com/yidongnan/grpc-spring-boot-starter/pull/775#issuecomment-1329023335

@jvmlet jvmlet added the dependency-upgrade Auto-generates notes label Dec 5, 2022
@jvmlet jvmlet added this to the 5.0.0 milestone Dec 5, 2022
@ceckhardt
Copy link

I can give specific errors as I find them. The first is SocketUtils is replaced with TestSocketUtils, so trying to write GRPC tests results in:

Caused by: java.lang.NoClassDefFoundError: org/springframework/util/SocketUtils at org.lognet.springboot.grpc.autoconfigure.GRpcServerProperties.lambda$getRunningPort$0(GRpcServerProperties.java:52)

jvmlet added a commit that referenced this issue Dec 8, 2022
jvmlet added a commit that referenced this issue Dec 8, 2022
@jvmlet
Copy link
Collaborator

jvmlet commented Dec 8, 2022

Please try with latest 5.0.0-SNAPSHOT

@ceckhardt
Copy link

I think there are some dependencies in 5.0.0-SNAPSHOT that should actually be changed to maven central. I get the following:
`

Could not resolve io.github.lognet:grpc-spring-boot-starter:5.0.0-SNAPSHOT.
> Could not parse POM https://oss.sonatype.org/content/repositories/snapshots/io/github/lognet/grpc-spring-boot-starter/5.0.0-SNAPSHOT/grpc-spring-boot-starter-5.0.0-20221208.132712-4.pom
> Could not resolve org.springframework.cloud:spring-cloud-dependencies:2022.0.0-RC3.
> Could not resolve org.springframework.cloud:spring-cloud-dependencies:2022.0.0-RC3.
> Could not get resource 'https://repo.spring.io/libs-release/org/springframework/cloud/spring-cloud-dependencies/2022.0.0-RC3/spring-cloud-dependencies-2022.0.0-RC3.pom'.
> Could not GET 'https://repo.spring.io/libs-release/org/springframework/cloud/spring-cloud-dependencies/2022.0.0-RC3/spring-cloud-dependencies-2022.0.0-RC3.pom'. Received status code 401 from server: Unauthorized
`

@jvmlet
Copy link
Collaborator

jvmlet commented Dec 12, 2022

@ceckhardt, would you please add https://repo.spring.io/milestone/ maven repository to your build and retry.

@jvmlet
Copy link
Collaborator

jvmlet commented Dec 12, 2022

Here is my config

allprojects {
    repositories {
        mavenCentral()
        maven { url 'https://repo.spring.io/release' }
        maven { url "https://jitpack.io" }
        maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
        maven { url 'https://repo.spring.io/snapshot' }
        maven { url "https://repo.spring.io/milestone" }

    }
}

@ceckhardt
Copy link

I can confirm all my gRPC spring boot 3 tests are now working with io.github.lognet:grpc-spring-boot-starter:5.0.0-SNAPSHOT

@deepaksrivastav
Copy link

I can also confirm this

@jvmlet jvmlet closed this as completed Jan 1, 2023
@jvmlet
Copy link
Collaborator

jvmlet commented Jan 1, 2023

5.0.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-upgrade Auto-generates notes
Projects
None yet
Development

No branches or pull requests

5 participants