Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata to consul service discovery #249

Closed
onyn opened this issue Oct 5, 2021 · 0 comments
Closed

Add metadata to consul service discovery #249

onyn opened this issue Oct 5, 2021 · 0 comments
Labels
enhancement Auto-generates notes
Milestone
4.5.9

Comments

@onyn
Copy link

onyn commented Oct 5, 2021

Consider adding metadata when registering grpc service in consul. Spring-cloud-consul already supports this.

Metadata may be taken from spring.cloud.consul.discovery.metadata. Or from custom property grpc.consul.metadata if someone wants separate metadata for http and grpc endpoints.

This feature is useful for publishing grpc service config.
@jvmlet jvmlet added the enhancement Auto-generates notes label Nov 1, 2021
@jvmlet jvmlet added this to the 4.5.9 milestone Nov 1, 2021
@jvmlet jvmlet closed this as completed in b13a9f8 Nov 1, 2021
jvmlet pushed a commit that referenced this issue Nov 3, 2021
test for #249
d8c6541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Auto-generates notes
Projects
None yet
Milestone
4.5.9
Development

No branches or pull requests
2 participants
@onyn @jvmlet