@set directive cannot have value with commas.

[jtskjelfjord]

When using the @set with a value that contains commas, like the following examples...

@set($product_name, apply_filters('woocommerce_cart_item_name', $_product->get_name(), $cart_item, $cart_item_key))

or...

@set($product_name, "string, with, commas")

will result in....

<?php $_product = apply_filters('woocommerce_cart_item_product'; ?>

...which has unfinished/unclosed parenthesis and all $args missing.

or like this...

<?php $product_name = "string; ?>

...which is missing the last double quote and the rest of the string.

My suggestion would be to add a third parameter in explode() for Util::parse() function like this...

public static function parse($expression)
{
    return collect(explode(',', $expression, 2))
        ->map(function ($item) {
            return trim($item);
        });
}

Adding 2 as the third parameter for explode() will make it so that it only explodes on the first comma.

Can confirm that this works with the two examples provided above.

Alternatively make a new second util method to prevent issues with existing directives that requires explode on all commas.

[Log1x]

I experienced this recently myself when trying to do @set($example, ['value', 'value']) – thanks for the tip on explode(), I didn't even know it had a third parameter if I'm being brutally honest lol.

I will make it so parse() can accept a bool as a second param to handle this situation. Would that be sane?

[Log1x]

I've pushed a next branch that adds $limit to the parse() method. I will probably go ahead and publish a release now, but there are more than likely other directives that would benefit from this being set accordingly.

If you're at all interested in doing a PR later on, that'd be awesome.

[jtskjelfjord]

You want me to PR for future issues? or for this issue? (i'm new to PR's, so i don't quite know how it works) Looked at your solution and that should work fine.

…

On Mon, Dec 2, 2019 at 3:53 PM Brandon ***@***.***> wrote: Closed #28 <#28>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#28?email_source=notifications&email_token=AB6N64UO7ITOL4DOIW6HG6TQWUONPA5CNFSM4JTVVIXKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVGRCUDY#event-2845977103>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6N64TUMAAPF2VHBLXEBDLQWUONPANCNFSM4JTVVIXA> .

-- Mvh Jan-Thore Skjelfjord *E-post:* [email protected] *Mobil:* 0738-26 37 45