feat: use proper states and make UtilityCard more generic #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apvale
requested review from
a team,
padulafacundo,
franziiiini,
rssilva and
pecavalheiro
🦋 Changeset detectedLatest commit: dec79d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +23 B (+0.05%) Total Size: 43.6 kB
ℹ️ View Unchanged
|
franziiiini
reviewed
Nov 15, 2024
| @@ -32,7 +33,11 @@ Default.args = { | |||
| export const CardWithBadge: Story = Template.bind({}); | |||
There was a problem hiding this comment.
Maybe we can add CardWithContent here as well?
apvale
force-pushed
the
feat/add-content-prop-to-utility-card
branch
2 times, most recently
from
acc83d8 to
fbd64a5
Compare
apvale
force-pushed
the
feat/add-content-prop-to-utility-card
branch
from
fbd64a5 to
dec79d9
Compare
apvale
changed the title
| - Renamed `categoryTag` to `subTitle` to make it more generic | ||
| - `onClick` prop is only required when using `clickable` as true | ||
|
|
||
| Minor: |
There was a problem hiding this comment.
is it fine that this is a major update but we include minor updates?
There was a problem hiding this comment.
From what we have here, I would say it's fine. Do you see any specific issue with it?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Breaking Change:
interactiveElementTypeprop in order to add two new states propertieshoverableandclickablecategoryTagtosubTitleto make it more genericonClickprop is only required when usingclickableas trueMinor:
hoverableandclickableto have more control of state of the cardemojiWrapperSizeprop with optionssmallandlargeso it's adaptable to different use casesindicatorto add a helper element to the top right of the cardTesting the change
Type of change
Development
Code review