Add nix.linux-builder.systems option to set corresponding nix.buildMachines.*.systems option
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
requested changes
Nov 22, 2023
Enzime
requested changes
Nov 22, 2023
|
@Enzime Thanks for the review, I've made those changes! |
ethnt
force-pushed
the
linux-builder-systems-config
branch
from
297bc79 to
72dd60b
Compare
Enzime
requested changes
Nov 23, 2023
| @@ -57,6 +57,22 @@ in | |||
| ''; | |||
| }; | |||
|
|
|||
| systems = mkOption { | |||
| type = types.listOf types.str; | |||
| default = [ "${stdenv.hostPlatform.uname.processor}-linux" ]; | |||
There was a problem hiding this comment.
Suggested change
| default = [ "${stdenv.hostPlatform.uname.processor}-linux" ]; | |
| default = [ "${stdenv.hostPlatform.uname.processor}-linux" ]; | |
| defaultText = literalExpression ''[ "''${stdenv.hostPlatform.uname.processor}-linux" ]''; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set up my local
linux-builderto emulatex86_64-linuxas well asaarch64-linux(jury's out as to how well that will work), but I still need to be able to set that option in/etc/nix/machines. I've added an option for this innix.linux-builder. Potentially in the future it would be a better idea to simply allowextraBuilderConfigor something similar, but I stuck with convention in this PR.