fix: use correct username for profile #1355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toodeluna
force-pushed
the
fix/profile-name
branch
from
602ddc5 to
f23a219
Compare
|
I think this isn’t the only place it is wrong, if you could fix all the places it is wrong that would be great See #294 |
toodeluna
force-pushed
the
fix/profile-name
branch
from
f23a219 to
608f498
Compare
|
The username should now be correct everywhere. I tested it with my own system flake and it all seems to work as expected now, but let me know if I've missed any other places. |
toodeluna
force-pushed
the
fix/profile-name
branch
from
608f498 to
6c72b68
Compare
Enzime
reviewed
Mar 5, 2025
toodeluna
force-pushed
the
fix/profile-name
branch
from
6c72b68 to
e279ac2
Compare
toodeluna
force-pushed
the
fix/profile-name
branch
from
e279ac2 to
deb46f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an inconsistency I've found between NixOS and Nix Darwin.
On NixOS this code will create the folder
/etc/profiles/per-user/actual_namewhereas on nix-darwin it creates/etc/profiles/per-user/myUser. This causes problems with certain modules in home-manager for example, which expects theactual_namefolder to exist.