Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XTest input fallback #997

Merged
merged 13 commits into from
Mar 8, 2023
Merged

Add XTest input fallback #997

merged 13 commits into from
Mar 8, 2023

Conversation

Doridian
Copy link
Contributor

@Doridian Doridian commented Mar 4, 2023

Description

This includes a way for Sunshine to utilize XTest for inputs in the event libev/uinput is unavailable (such as inside an un-privileged Docker container)

Let me know how this looks code-wise. Likely the direct calling of X functions needs to be changed, considering you seem to use the dyn::load semantics elsewhere. Done

This also removes the useless pressed integer (grabbing the value out of the array creates a copy, so pressed was never actually anything but 0)

It also removes the loops in init_keycodes, most of which were useless (as they were all explicitly mentioned via __CONVERT), and replaces them with full explicit key constants.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the base branch from master to nightly March 4, 2023 19:13
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

@ReenigneArcher
Copy link
Member

Are you on our discord server so we can discuss this in real time?

@Doridian
Copy link
Contributor Author

Doridian commented Mar 7, 2023

@ReenigneArcher Just joined, same name as on GitHub.

@ReenigneArcher ReenigneArcher merged commit 8227e8f into LizardByte:nightly Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants