Update ffmpeg

[PapyKahan]

Description

Changes to be able to update FFMPEG dependency. I've removed duplicated implementation of cbs. There's an implementation into libavcodec now. I've left existing headers to be able to build and expose cbs implementation of FFMPEG.

I've also fix a segmentation fault introduced with FFMPEG update by setting default values into AVPacket struct.

Issues Fixed or Closed

• Fixes FFMPEG dependency update #44

Type of Change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the documentation blocks for new or existing components

[github-actions]

Pull requests must be made to the nightly branch. Thanks.

[PapyKahan]

a SunshineStream/Sunshine-Windows-Prebuilt release needs to be done and referenced into CMakeList.txt in order to build this pull-request.

[ReenigneArcher]

a SunshineStream/Sunshine-Windows-Prebuilt release needs to be done and referenced into CMakeList.txt in order to build this pull-request.

@TheElixZammuto can you create a release of your prebuild in this org? I saw there is a workflow there to create the release. Might be worth adding a dispatch event trigger to it (so it can be run manually). And perhaps only run the workflow on push/pull request to certain branches?

Edit: In process, see here: https://github.com/SunshineStream/Sunshine-Windows-Prebuilt/pull/1

[ReenigneArcher]

So, looks like Windows is building okay. What do we need to do to get the building on Linux functional again? Can we use a pre-built like on Windows?

[ReenigneArcher]

Are these changes to ffmpeg only required for building, or also required during runtime?

[ReenigneArcher]

@PapyKahan I've updated the prebuild repo to include a build of ffmpeg on debian. Also the repo name changed.

Would you mind updating to point to the -windows package? And do you have any idea about building properly on linux? I'm hoping that -debian package can resolve the issues we're seeing in the build here.

https://github.com/SunshineStream/ffmpeg-prebuilt/releases/tag/v1

[GeoDerp]

Im not sure if this will help but while testing my rpm spec #7 with this branch I get

/home/Geo/rpmbuild/BUILD/sunshine-master/sunshine/video.h:30:5: error: 'opaque' was not declared in this scope
   30 |     opaque          = nullptr;
      |     ^~~~~~
/home/Geo/rpmbuild/BUILD/sunshine-master/sunshine/video.h:31:5: error: 'opaque_ref' was not declared in this scope
   31 |     opaque_ref      = nullptr;
      |     ^~~~~~~~~~

[ReenigneArcher]

Im not sure if this will help but while testing my rpm spec #7 with this branch I get

/home/Geo/rpmbuild/BUILD/sunshine-master/sunshine/video.h:30:5: error: 'opaque' was not declared in this scope
   30 |     opaque          = nullptr;
      |     ^~~~~~
/home/Geo/rpmbuild/BUILD/sunshine-master/sunshine/video.h:31:5: error: 'opaque_ref' was not declared in this scope
   31 |     opaque_ref      = nullptr;
      |     ^~~~~~~~~~

We're aware of the issue. https://github.com/SunshineStream/Sunshine/runs/5174320304?check_suite_focus=true

[GeoDerp]

Im not sure if this will help but while testing my rpm spec #7 with this branch I get

/home/Geo/rpmbuild/BUILD/sunshine-master/sunshine/video.h:30:5: error: 'opaque' was not declared in this scope
   30 |     opaque          = nullptr;
      |     ^~~~~~
/home/Geo/rpmbuild/BUILD/sunshine-master/sunshine/video.h:31:5: error: 'opaque_ref' was not declared in this scope
   31 |     opaque_ref      = nullptr;
      |     ^~~~~~~~~~

We're aware of the issue. https://github.com/SunshineStream/Sunshine/runs/5174320304?check_suite_focus=true

sorry, that was me being dumb and not using ffmpeg-5.... And not reading the messages above first.

[github-actions]

This PR is stale because it has been open for 30 days with no activity. Remove the stale label or comment, otherwise this will be closed in 5 days.

[github-actions]

This PR was closed because it has been stalled for 5 days with no activity.