-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(display): Add revert display config on disconnect option #3613
feat(display): Add revert display config on disconnect option #3613
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cfa52d8
to
5a02712
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just linter errors
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3613 +/- ##
==========================================
- Coverage 11.62% 11.62% -0.01%
==========================================
Files 93 93
Lines 17318 17321 +3
Branches 8091 8093 +2
==========================================
Hits 2014 2014
- Misses 12820 14713 +1893
+ Partials 2484 594 -1890
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
This adds the option to revert the display configuration changes on disconnect of the client instead of waiting for the termination of the session or app. It's set off by default as I expect some applications don't always play well with a resolution change while active and many users may just not want this behavior by default.
This was a feature I found a use for and figured some others may as well. Happy to make any changes as desired!
Screenshot
Issues Fixed or Closed
None
Type of Change
.github/...
)Checklist