Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(display): Add revert display config on disconnect option #3613

Conversation

VMFortress
Copy link
Contributor

Description

This adds the option to revert the display configuration changes on disconnect of the client instead of waiting for the termination of the session or app. It's set off by default as I expect some applications don't always play well with a resolution change while active and many users may just not want this behavior by default.

This was a feature I found a use for and figured some others may as well. Happy to make any changes as desired!

Screenshot

Screenshot_20250130_130859

Issues Fixed or Closed

None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher

This comment was marked as resolved.

FrogTheFrog

This comment was marked as resolved.

FrogTheFrog

This comment was marked as resolved.

Copy link
Collaborator

@FrogTheFrog FrogTheFrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReenigneArcher ReenigneArcher force-pushed the feat/display/config_revert_on_disconnect branch from cfa52d8 to 5a02712 Compare January 30, 2025 20:02
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just linter errors

src/stream.cpp Outdated Show resolved Hide resolved
src/stream.cpp Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) January 30, 2025 20:19
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 11.62%. Comparing base (ce28e36) to head (cdc30a5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/stream.cpp 0.00% 2 Missing ⚠️
src/config.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
- Coverage   11.62%   11.62%   -0.01%     
==========================================
  Files          93       93              
  Lines       17318    17321       +3     
  Branches     8091     8093       +2     
==========================================
  Hits         2014     2014              
- Misses      12820    14713    +1893     
+ Partials     2484      594    -1890     
Flag Coverage Δ
Linux 11.30% <0.00%> (-0.01%) ⬇️
Windows 13.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.h 0.00% <ø> (ø)
src/config.cpp 0.00% <0.00%> (ø)
src/stream.cpp 2.51% <0.00%> (-0.01%) ⬇️

... and 29 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 5b36357 into LizardByte:master Jan 30, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants