Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): allow encoder probing when there are no devices at all #3594

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

FrogTheFrog
Copy link
Collaborator

Description

It is possible that if there are no devices reported, that the API is not functioning properly. Make sure not to prevent encoding in such cases if we can't tell.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 11.62%. Comparing base (24cce3a) to head (835ccb7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/video.cpp 0.00% 9 Missing ⚠️
src/display_device.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
- Coverage   11.63%   11.62%   -0.01%     
==========================================
  Files          93       93              
  Lines       17314    17318       +4     
  Branches     8086     8091       +5     
==========================================
  Hits         2014     2014              
- Misses      14706    14710       +4     
  Partials      594      594              
Flag Coverage Δ
Linux 11.30% <0.00%> (-0.01%) ⬇️
Windows 13.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/display_device.cpp 54.94% <0.00%> (+0.31%) ⬆️
src/video.cpp 21.73% <0.00%> (-0.13%) ⬇️

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher ReenigneArcher merged commit 23e1314 into LizardByte:master Jan 27, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants