feat!: drop advertised resolutions and fps

[ReenigneArcher]

Description

Drop support for advertised resolutions and fps. Any clients still using this?

Moonlight maintainers, please verify this doesn't break any of your clients.

• @cgutman (Official)
• @TheElixZammuto (UWP/Xbox)
• @XITRIX (Switch)
• @GaryOderNichts (Wii U)
• @mariotaku (LG webOS)
• @xyzz (Vita)
• @KyroFrCode (Tizen fork 1)
• @OneLiberty (Tizen fork 2)

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.67%. Comparing base (64083c1) to head (d9a3c22).
Report is 138 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #2924      +/-   ##
=========================================
+ Coverage    9.65%   9.67%   +0.01%     
=========================================
  Files          97      97              
  Lines       17557   17526      -31     
  Branches     8230    8199      -31     
=========================================
  Hits         1696    1696              
+ Misses      12998   12993       -5     
+ Partials     2863    2837      -26     

Flag	Coverage Δ
Linux	7.17% <ø> (+0.01%)	⬆️
Windows	5.09% <ø> (+<0.01%)	⬆️
macOS-12	10.33% <ø> (+0.03%)	⬆️
macOS-13	10.24% <ø> (+0.02%)	⬆️
macOS-14	10.56% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.cpp	4.89% <ø> (+0.11%)	⬆️
src/config.h	0.00% <ø> (ø)
src/nvhttp.cpp	1.22% <ø> (+0.03%)	⬆️

[mariotaku]

I tried to ignore display modes and didn't see any problem.

[XITRIX]

Switch client still rely on it, will try to add required changes in near future

[GaryOderNichts]

Wii U uses @mariotaku's modified libgamestream, which still parses the supported modes. I'm not sure if this will fail, if the server doesn't respond with them. I'll have to test this later.

[TheElixZammuto]

Moonlight UWP does work as expected with this version of Sunshine. My libgamestream is derived from the moonlight-embedded one btw, but the app never checked the supported resolutions.

[XITRIX]

I've made all necessary modifications, Moonlight-Switch v1.2.0 release should works fine without screen modes list