Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS4 touchpad button support #1401

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jun 28, 2023

Description

This PR pulls out the extended button support and gamepad count fix from #1396 since they are trivial changes and don't depend on any of the major new protocol work happening in that branch.

Clients supporting these new button flags aren't released yet, but support is present in the Qt and Android clients as of now. iOS will probably be done in the coming few days.

Screenshot

Issues Fixed or Closed

Fixes #1362

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman merged commit 12e6774 into LizardByte:nightly Jun 28, 2023
@cgutman cgutman added the protocol update This PR includes an update to the streaming protocol label Jul 11, 2023
@cgutman cgutman mentioned this pull request Jul 31, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol update This PR includes an update to the streaming protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant