Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty HPO error. #72

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix empty HPO error. #72

merged 2 commits into from
Aug 23, 2024

Conversation

hyunhwan-bcm
Copy link
Contributor

The HPO correction in main hadn't applied to nextflow_conversion.

if [[ -z $(egrep 'HP:[0-9]{7}' /input/hpo.txt) ]] ; then

Now the code for handling the empty/invalid HPO has been added in HPO_SIM, and here is the output from the workdir:

❯ cd ef/e2e89a3bc359568cbd931485ff0096
❯ ls
 70M 22 Aug 15:16  1-cz
2.8M 22 Aug 15:16  1-dx
   - 22 Aug 15:15  demo_empty_HPO.txt -> /Users/hyun-hwanjeong/Downloads/demo_empty_HPO.txt
   - 22 Aug 15:15  genemap2_v2022.rds -> /Volumes/HWAN-T7/data-dependency/omim_annotate/hg19/genemap2_v2022.rds
   - 22 Aug 15:15  HGMD_phen.tsv -> /Volumes/HWAN-T7/data-dependency/omim_annotate/hg19/HGMD_phen.tsv
   - 22 Aug 15:15  hp.obo -> /Volumes/HWAN-T7/data-dependency/omim_annotate/hp.obo
   - 22 Aug 15:15  HPO_OMIM.tsv -> /Volumes/HWAN-T7/data-dependency/omim_annotate/hg19/HPO_OMIM.tsv
❯ cat demo_empty_HPO.txt
HP:0000001

@hyunhwan-bcm hyunhwan-bcm added the bug Something isn't working label Aug 22, 2024
@hyunhwan-bcm hyunhwan-bcm added this to the v1.0 milestone Aug 22, 2024
@hyunhwan-bcm hyunhwan-bcm requested a review from arine August 22, 2024 20:19
@hyunhwan-bcm hyunhwan-bcm self-assigned this Aug 22, 2024
@arine arine merged commit b98dbc0 into nextflow_conversion Aug 23, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants