Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify exonic filtering parameters and add bed filter option #48

Closed
3 tasks
hyunhwan-bcm opened this issue Aug 13, 2024 · 4 comments
Closed
3 tasks

Modify exonic filtering parameters and add bed filter option #48

hyunhwan-bcm opened this issue Aug 13, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@hyunhwan-bcm
Copy link
Contributor

Description

We need to make changes to the exonic filtering parameters in our Nextflow script to improve clarity and add more flexibility. This involves renaming an existing parameter and adding a new one with higher priority.

Proposed Changes

  1. Rename --no_filter_exonic to --exome_filter
  2. Add a new parameter --bed_filter
  3. Modify the filtering logic to prioritize --bed_filter over --exome_filter

Implementation Details

1. Rename parameter

  • Change --no_filter_exonic to --exome_filter
  • Update the logic to check if --exome_filter is true (instead of false)

2. Add new parameter

  • Add --bed_filter option
  • This parameter should accept a path to a BED file for custom filtering

3. Modify filtering logic

  • If --bed_filter is provided, use it for filtering regardless of --exome_filter setting
  • If --bed_filter is not provided, then check --exome_filter
  • Update the FILTER_EXONIC process to implement this logic

Code Changes

Update the FILTER_EXONIC process (around line 53) to something like this:

Tasks

  • Rename --no_filter_exonic to --exome_filter throughout the codebase
  • Add --bed_filter parameter to the script
  • Update the `
@hyunhwan-bcm hyunhwan-bcm added the enhancement New feature or request label Aug 13, 2024
@jylee-bcm
Copy link
Contributor

Do you mean the default behavior is not performing the filtering? then it's good.

@hyunhwan-bcm
Copy link
Contributor Author

please read the entire document carefully, this issue not only asking this but also add additional thing needs to be done. The current version the default parameter no_filter_exonic = false, then I believe it executes a filtering as default, isn't it?

@jylee-bcm
Copy link
Contributor

Gotcha. I will work on it

@hyunhwan-bcm
Copy link
Contributor Author

Thanks!

jylee-bcm added a commit that referenced this issue Aug 13, 2024
hyunhwan-bcm added a commit that referenced this issue Aug 14, 2024
Add Bed Filter Parameter and Close #48
@hyunhwan-bcm hyunhwan-bcm added this to the v1.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants