Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add isCertificateGenerated check to unlock command - Closes #6857 #6979

Merged
merged 15 commits into from
Jan 19, 2022
Merged

Add isCertificateGenerated check to unlock command - Closes #6857 #6979

merged 15 commits into from
Jan 19, 2022

Conversation

mitsuaki-u
Copy link
Contributor

What was the problem?

This PR resolves #6857

How was it solved?

  • 🌱 Added isCertificateGenerated util function
  • 🌱 Added check to unlock command

How was it tested?

Updated tests

@mitsuaki-u mitsuaki-u self-assigned this Jan 14, 2022
@shuse2 shuse2 linked an issue Jan 14, 2022 that may be closed by this pull request
Add isCertificateGenerated check in unlock command for DPoS module #6857
Closed
@mitsuaki-u mitsuaki-u requested review from shuse2 and ishantiw January 14, 2022 14:24
ishantiw
ishantiw reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of comments

shuse2
shuse2 reviewed Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @ishantiw 's comment LGTM

@mitsuaki-u mitsuaki-u mentioned this pull request Jan 18, 2022
Merged
shuse2
shuse2 suggested changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have positive scenario as well

framework/test/unit/modules/dpos_v2/commands/unlock.spec.ts Show resolved Hide resolved
framework/test/unit/modules/dpos_v2/commands/unlock.spec.ts Show resolved Hide resolved
@shuse2 shuse2 merged commit 2ac731f into feature/6554-improve-framework-architecture Jan 19, 2022
@shuse2 shuse2 deleted the 6857_unlock_cmd branch January 19, 2022 13:52
@ishantiw ishantiw mentioned this pull request Dec 8, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@shuse2 shuse2 shuse2 approved these changes

Assignees

@mitsuaki-u mitsuaki-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add isCertificateGenerated check in unlock command for DPoS module
3 participants
@mitsuaki-u @shuse2 @ishantiw