-
Notifications
You must be signed in to change notification settings - Fork 60
Conversation
The previous version doesn't show Forged blocks header if the list is empty. instead it shows a message: You have not forged any blocks yet. I think it makes sense to keep the same behaviour. |
I can't find how have you fixed these issues:
|
"Rank higher by 1" was actually a slightly different problem. |
49ba5bb
to
4e543d3
Compare
fb6363a
to
132340c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Vit. All changes are good. I've just added comments on an action usage.
|
||
middleware(store)(next)({ type: actionTypes.metronomeBeat }); | ||
|
||
expect(stubGetAccount).to.have.been.calledWith(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is not related to title.
The issue is, Actions that we create using Redux thunk don't return object. They return a function which accepts dispatch
as argument. but you're using just like other actions.
Other than how you've used it, the actual issue is as described above it best called inside component class.
Closes #618