Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix issues in forging - Closes #618 #630

Merged
merged 7 commits into from
Aug 28, 2017
Merged

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Aug 21, 2017

Closes #618

@slaweet slaweet self-assigned this Aug 21, 2017
@slaweet slaweet requested a review from yasharAyari August 21, 2017 15:16
@reyraa reyraa self-requested a review August 22, 2017 13:50
@reyraa
Copy link
Contributor

reyraa commented Aug 22, 2017

The previous version doesn't show Forged blocks header if the list is empty. instead it shows a message: You have not forged any blocks yet. I think it makes sense to keep the same behaviour.

@reyraa
Copy link
Contributor

reyraa commented Aug 22, 2017

I can't find how have you fixed these issues:

shows Rank higher by 1
Forged blocks don’t get updates after the initial load

@slaweet
Copy link
Contributor Author

slaweet commented Aug 22, 2017

"Rank higher by 1" was actually a slightly different problem.
I was testing on delegate with rank 50 and it showed 51. But later when I tried rank 49, it showed 52. So it was subtracting from 101, the same way it does for the progress bar. The fix is this:
9247adf

@slaweet slaweet force-pushed the 618-issues-in-forging branch from 49ba5bb to 4e543d3 Compare August 23, 2017 10:47
@slaweet slaweet removed the request for review from yasharAyari August 24, 2017 12:00
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vit. All changes are good. I've just added comments on an action usage.


middleware(store)(next)({ type: actionTypes.metronomeBeat });

expect(stubGetAccount).to.have.been.calledWith();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not related to title.
The issue is, Actions that we create using Redux thunk don't return object. They return a function which accepts dispatch as argument. but you're using just like other actions.

Other than how you've used it, the actual issue is as described above it best called inside component class.

@slaweet slaweet merged commit 4ac073d into development Aug 28, 2017
@slaweet slaweet deleted the 618-issues-in-forging branch August 28, 2017 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants