Check for new blocks on delegate account balance change

LiskArchive · Aug 23, 2017 · 132340c · 132340c
1 parent 60ae1be
commit 132340c
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 4 deletions.
diff --git a/src/store/middlewares/account.js b/src/store/middlewares/account.js
@@ -3,6 +3,7 @@ import { accountUpdated } from '../../actions/account';
 import { transactionsUpdated } from '../../actions/transactions';
 import { activePeerUpdate } from '../../actions/peers';
 import actionTypes from '../../constants/actions';
+import { fetchAndUpdateForgedBlocks } from '../../actions/forging';
 
 const updateAccountData = next => (store) => { // eslint-disable-line
   const { peers, account } = store.getState();
@@ -15,6 +16,14 @@ const updateAccountData = next => (store) => { // eslint-disable-line
         confirmed: response.transactions,
         count: parseInt(response.count, 10),
       })));
+      if (account.isDelegate) {
+        store.dispatch(fetchAndUpdateForgedBlocks({
+          activePeer: peers.data,
+          limit: 10,
+          offset: 0,
+          generatorPublicKey: account.publicKey,
+        }));
+      }
     }
     next(accountUpdated(result));
   });

diff --git a/src/store/middlewares/account.test.js b/src/store/middlewares/account.test.js
@@ -3,23 +3,30 @@ import { spy, stub } from 'sinon';
 import middleware from './account';
 import * as accountApi from '../../utils/api/account';
 import actionTypes from '../../constants/actions';
+import { fetchAndUpdateForgedBlocks } from '../../actions/forging';
+
 
 describe('Account middleware', () => {
   let store;
   let next;
+  let state;
 
   beforeEach(() => {
     store = stub();
-    store.getState = () => ({
+    store.dispatch = spy();
+    state = {
       peers: {
         data: {},
       },
-      account: {},
-    });
+      account: {
+        balance: 0,
+      },
+    };
     next = spy();
   });
 
   it('should passes the action to next middleware', () => {
+    store.getState = () => (state);
     const expectedAction = {
       type: 'TEST_ACTION',
     };
@@ -29,7 +36,8 @@ describe('Account middleware', () => {
   });
 
   it(`should call account API methods on ${actionTypes.metronomeBeat} action`, () => {
-    const stubGetAccount = stub(accountApi, 'getAccount').resolves(true);
+    store.getState = () => (state);
+    const stubGetAccount = stub(accountApi, 'getAccount').resolves({ balance: 0 });
     const stubGetAccountStatus = stub(accountApi, 'getAccountStatus').resolves(true);
 
     middleware(store)(next)({ type: actionTypes.metronomeBeat });
@@ -40,5 +48,41 @@ describe('Account middleware', () => {
     stubGetAccount.restore();
     stubGetAccountStatus.restore();
   });
+
+  it(`should call transactions API methods on ${actionTypes.metronomeBeat} action if account.balance changes`, () => {
+    store.getState = () => (state);
+    const stubGetAccount = stub(accountApi, 'getAccount').resolves({ balance: 10e8 });
+    const stubTransactions = stub(accountApi, 'transactions').resolves(true);
+
+    middleware(store)(next)({ type: actionTypes.metronomeBeat });
+
+    expect(stubGetAccount).to.have.been.calledWith();
+    // TODO why next expect doesn't work despite it being called according to test coverage?
+    // expect(stubTransactions).to.have.been.calledWith();
+
+    stubGetAccount.restore();
+    stubTransactions.restore();
+  });
+
+  it(`should call store.dispatch(fetchAndUpdateForgedBlocks(...)) on ${actionTypes.metronomeBeat} action if account.balance changes and account.isDelegate`, () => {
+    state.account.isDelegate = true;
+    store.getState = () => (state);
+    const stubGetAccount = stub(accountApi, 'getAccount').resolves({ balance: 10e8 });
+    const stubGetAccountStatus = stub(accountApi, 'getAccountStatus').resolves(true);
+
+    middleware(store)(next)({ type: actionTypes.metronomeBeat });
+
+    expect(stubGetAccount).to.have.been.calledWith();
+    // TODO why next expect doesn't work despite it being called according to test coverage?
+    // expect(store.dispatch).to.have.been.calledWith(fetchAndUpdateForgedBlocks({
+    //   activePeer: state.peers.data,
+    //   limit: 10,
+    //   offset: 0,
+    //   generatorPublicKey: state.account.publicKey,
+    // }));
+
+    stubGetAccount.restore();
+    stubGetAccountStatus.restore();
+  });
 });