Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create redux state for hardware wallet #4805

Merged
merged 19 commits into from
Feb 20, 2023
Merged

Create redux state for hardware wallet #4805

merged 19 commits into from
Feb 20, 2023

Conversation

oskarleonard
Copy link
Contributor

@oskarleonard oskarleonard commented Feb 13, 2023 •
edited
Loading

What was the problem?

This PR resolves #4777

How was it solved?

  • Displaying toast messages when the HW is connected or disconnected
  • Display a toast with an option to navigate to the switch device modal if more than one HW is connected.
  • Add a React hook listener which populates redux with events coming from hardware server
  • Added a skeleton modal for switching hardware wallets. Which will be completed in Add support for switching between HW devices #4770

How was it tested?

Unit tests and manually

@oskarleonard oskarleonard changed the title Add missing id argument to deviceUpdate Create redux state for hardware wallet Feb 13, 2023
@oskarleonard oskarleonard marked this pull request as draft February 13, 2023 15:08
@oskarleonard oskarleonard marked this pull request as ready for review February 14, 2023 11:31
@ManuGowda ManuGowda closed this Feb 14, 2023
@ManuGowda ManuGowda deleted the 4777-create-redux-state-for-hardware-wallet branch February 14, 2023 11:35
@ManuGowda ManuGowda restored the 4777-create-redux-state-for-hardware-wallet branch February 14, 2023 11:54
@ManuGowda ManuGowda reopened this Feb 14, 2023
@ManuGowda ManuGowda assigned ManuGowda and oskarleonard and unassigned ManuGowda Feb 14, 2023
@soroushm soroushm force-pushed the 4777-create-redux-state-for-hardware-wallet branch from 29965da to 74c4bde Compare February 16, 2023 16:35
@soroushm soroushm force-pushed the 4777-create-redux-state-for-hardware-wallet branch from 74c4bde to c7618dd Compare February 16, 2023 16:39
@soroushm soroushm force-pushed the 4777-create-redux-state-for-hardware-wallet branch from 35ad9f5 to 611d9a2 Compare February 16, 2023 18:36
soroushm
soroushm previously approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@soroushm soroushm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikem-legend ikem-legend self-requested a review February 17, 2023 16:33
@ikem-legend ikem-legend requested a review from soroushm February 17, 2023 16:46
@oskarleonard oskarleonard merged commit 1406f4e into feature/adapt-hw Feb 20, 2023
@oskarleonard oskarleonard deleted the 4777-create-redux-state-for-hardware-wallet branch February 20, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soroushm soroushm soroushm approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

@eniolam1000752 eniolam1000752 Awaiting requested review from eniolam1000752

Assignees

@oskarleonard oskarleonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oskarleonard @soroushm @ikem-legend @ManuGowda