Fix events table styling #4754
Merged
Fix events table styling #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eniolam1000752
previously approved these changes
Jan 23, 2023
ManuGowda
requested review from
ManuGowda and
oskarleonard
and removed request for
oskarleonard and
ManuGowda
ManuGowda
suggested changes
Jan 23, 2023
There was a problem hiding this comment.
@ikem-legend @eniolam1000752 this shouldn't be a link when -
when there is no transaction id, users shouldn't navigate/redirect, the - should be displayed
| @@ -47,3 +47,8 @@ h1 { | |||
| .wrapper { | |||
| margin-bottom: 25px; | |||
| } | |||
|
|
|||
| .content { | |||
There was a problem hiding this comment.
It would be nice if we could refactor away from important and be more fine grained with how important/fine grained a rule is. For example is this specific enough?
.wrapper {
margin-bottom: 25px;
& .content {
padding-left: 0;
padding-right: 0;
}
}
oskarleonard
previously approved these changes
Jan 23, 2023
|
Since |
ManuGowda
reviewed
Jan 23, 2023
ikem-legend
dismissed stale reviews from oskarleonard and eniolam1000752
via
50ea40e
oskarleonard
approved these changes
Jan 23, 2023
ManuGowda
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4735
How was it solved?
How was it tested?
Visually