Fix rpc api call #4725
Merged
Fix rpc api call #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soroushm
force-pushed
the
4724-fix-rpc-api-call
branch
from
c5d3f3e to
2d1a2a3
Compare
soroushm
force-pushed
the
4724-fix-rpc-api-call
branch
2 times, most recently
from
7d8195a to
18d58c9
Compare
chore: fix rpc call
soroushm
force-pushed
the
4724-fix-rpc-api-call
branch
from
2ced1e6 to
2b596b3
Compare
oskarleonard
approved these changes
Jan 18, 2023
eniolam1000752
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4724
How was it solved?
by changing the response to result and using socketRPC
How was it tested?
Unit test