Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dpos update #4671

Merged
merged 460 commits into from
Feb 14, 2023
Merged

Feature/dpos update #4671

merged 460 commits into from
Feb 14, 2023

Conversation

soroushm
Copy link
Contributor

What was the problem?

This PR resolves #4516

How was it solved?

its in progress

How was it tested?

unit test

@soroushm soroushm self-assigned this Dec 14, 2022
oskarleonard and others added 28 commits January 16, 2023 17:34
@oskarleonard
Add a workable mock image
2b5957e
@oskarleonard
Use same multistep as in unlockbalanceView
4ad34ff
@oskarleonard
Add initial color when hover a disabled button to prevent the text fr…
ee8f0c5 
…om changing color
@oskarleonard
Use transformResult instead of select
888fc59
@oskarleonard
Dont refetch if modal is open
db066d0
@oskarleonard
Clean duplicate code and prettify
54ea755
@oskarleonard
Make use of already existing useRewardsClaimable hook
0287ba4
@oskarleonard
add useSentStakesWithValidators hook
8dadbf0
@ManuGowda
Update lisk client to alpha.11 (#4723)
9b5e14d 
* ⬆️ Bump lisk-client version

* 🔥 Remove unused import
@soroushm
fixup! chore: fix rpc call
27d8201 
chore: fix rpc call
@soroushm
chore: change hardcoded limit on token balance
2b596b3
@oskarleonard
No need to merge validators to stakes, having the hook in the SentSta…
71dfdb0 
…kesRow is fine
Merge branch 'feature/dpos-update' into 4724-fix-rpc-api-call
65237d2
@oskarleonard
Use useSentStakes for query table
e4c0704
@oskarleonard
Dont disable button if there are any kinds of pendingUnlocks
f1bdca0
@oskarleonard
Correctly calculate sentStakesAmount and unlockableBalance
8d26404
@oskarleonard
Dont fetch unlocks if we dont provide the required params
bb659c2
@oskarleonard
Default to fetch all unlocks if a limit is not provided in customConfig
4186a7c
@oskarleonard
Fix calculation bug
e82547c
@oskarleonard
Rename variables
fa7e164
@oskarleonard
Dont fetch sentStakes if we dont have the required params
24cf1c1
@oskarleonard
Fix typo
fd401c8
@oskarleonard
Prettify StakesCount
a6cd3c0
@oskarleonard
Fix typo
fa710c7
@oskarleonard
Remove space
5d47f20
@oskarleonard
Fix typo
248a52e
@oskarleonard
Dont use currentBlockHeight check for checking if object is unlockabl…
02bf3bf 
…e, this is done in the backend, we can just check the unlockable field
@oskarleonard
Remove unnecessary optional chaining
580b0fe
@soroushm soroushm marked this pull request as ready for review February 9, 2023 11:59
ManuGowda and others added 16 commits February 9, 2023 18:28
@ManuGowda @eniolam1000752
Transaction page should not crash (#4798)
e15672d 
* 🐛 Add missing key value to avoid crashing

* Apply suggestions from code review

Co-authored-by: Eniola Olatunji <[email protected]>

---------

Co-authored-by: Eniola Olatunji <[email protected]>
@soroushm
feat: convert commission to percentage
bd98437 
feat: change commission
@soroushm
feat: add size support for TxSummarizer
7701492
@soroushm
chore: min
7b1b576 
or validation changes
@soroushm
test: add coverage for getValidatorCommission
49a0930
@soroushm
test: add coverage for ChangeCommissionDialog
6cebde8
@soroushm
test: add coverage for useCurrentCommissionPercentage
48b7dc7
@soroushm
test: add coverage for ChangeCommissionInfo and add missing convert f…
de352b4 
…unction
@soroushm
test: add coverage for ChangeCommissionStatus
74a946d
@soroushm
test: add coverage for ChangeCommissionSummary
98e06db
@soroushm
chore: add missing translation
c738328
@soroushm
chore: resolve pr discussion
8f477e6
@soroushm
chore: show edit commission only for my profile
b03188d
@soroushm
chore: make it pretty
cc711b9
@soroushm
test: add unit test for ChangeCommissionForm
1de3d3a
@ikem-legend
Merge pull request #4714 from LiskHQ/4642-edit-commission
44e133c 
Add change commission
@soroushm soroushm requested a review from ManuGowda February 13, 2023 00:55
@ManuGowda
Copy link
Contributor

The feature branch is currently difficult to test as we do not have the network setup to support the review of features. However on devnet environment the following are verified

  • All the new pos commands are working (with bugs/missing implementation)
  • Unable to test the following commands
    • Rewards claim
    • Unlock tokens

We will test all the pending features from development branch hence merging this feature branch.

@ManuGowda ManuGowda merged commit 001019a into development Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@soroushm soroushm

Labels
None yet
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DPoS module
6 participants
@soroushm @ManuGowda @oskarleonard @ikem-legend @eniolam1000752 @reyraa