Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue with send tx from a multi-sig account #4654

Merged

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Dec 7, 2022

What was the problem?

This PR resolves #4622, #4595

How was it solved?

  • Resolve inability to sign send transaction from a multi signature account
  • Resolve wrong tx fee on send transaction from a multi signature account
  • Confirm and ensure delegate registration works

How was it tested?

  • Jest
  • Visually

@eniolam1000752 eniolam1000752 self-assigned this Dec 7, 2022
@eniolam1000752 eniolam1000752 marked this pull request as ready for review December 7, 2022 14:52
@ManuGowda
Copy link
Contributor

@eniolam1000752 I am unable to register delegate from a multisignature account
Screenshot 2022-12-08 at 2 12 06 PM

Steps:

  • Register multisignature account
  • Register delegate from the upgraded multisignature account

Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eniolam1000752 multisig registration is working.
delegate registration also works on regular account, but delegate registration on a multisig account stops at sign flow.

Also I see lot of TODOs can you please create a GitHub issue to address these TODOs

@ManuGowda
Copy link
Contributor

  • Information shown is incorrect (rank, last block forged, voters)

Screenshot 2022-12-08 at 2 20 25 PM

  • Delegate is registered

Screenshot 2022-12-08 at 2 19 49 PM

  • Delegates tab doesn't show my profile instead still shows register delegate

Screenshot 2022-12-08 at 2 19 38 PM

@eniolam1000752
Copy link
Contributor Author

@ManuGowda I think the issue with the UI would be attended to by the validator tasks. I would align with @soroushm to see how these tasks can be modified

@ManuGowda ManuGowda merged commit 56701e2 into development Dec 9, 2022
@ManuGowda ManuGowda deleted the 4622-unable-to-transfer-token-from-multisig-account branch December 9, 2022 15:37
@ManuGowda ManuGowda restored the 4622-unable-to-transfer-token-from-multisig-account branch November 17, 2023 17:36
@ManuGowda ManuGowda deleted the 4622-unable-to-transfer-token-from-multisig-account branch November 27, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Unable to transfer token from multisignature account
3 participants