Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account transactions should use updated api #4618

Conversation

oskarleonard
Copy link
Contributor

@oskarleonard oskarleonard commented Nov 30, 2022

What was the problem?

This PR resolves #4217

How was it solved?

  • By converting dateTo and dateFrom to the supported API param timestamp. This is now done in the same way as on the transaction view
  • Removed amount filtering, it is no longer supported by the API

How was it tested?

Manually

@oskarleonard oskarleonard changed the title 4217 account transactions should use updated api - Closes #4217 4217 account transactions should use updated api Dec 1, 2022
@oskarleonard oskarleonard changed the title 4217 account transactions should use updated api Account transactions should use updated api Dec 1, 2022
@ManuGowda ManuGowda removed the request for review from soroushm December 1, 2022 14:17
@oskarleonard oskarleonard merged commit 9933525 into feature/4034-change-sdk-api Dec 1, 2022
@ManuGowda ManuGowda deleted the 4217-account-transactions-should-use-updated-api branch December 1, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants