Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox should not look like radio button #4615

Conversation

oskarleonard
Copy link
Contributor

What was the problem?

This PR resolves #4590

How was it solved?

  • By lessening border radius on the checkbox
  • By removing the warning "A component is changing an uncontrolled input to be controlled" in the checkbox as well as the SetPasswordForm.

How was it tested?

Manually

@ManuGowda ManuGowda self-requested a review December 1, 2022 08:39
@oskarleonard oskarleonard changed the title Checkbox should not look like radio button - Closes #4590 Checkbox should not look like radio button Dec 1, 2022
ManuGowda
ManuGowda previously approved these changes Dec 1, 2022
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManuGowda ManuGowda requested a review from soroushm December 1, 2022 10:34
@ManuGowda ManuGowda removed the request for review from soroushm December 1, 2022 11:40
@ikem-legend ikem-legend requested a review from ManuGowda December 1, 2022 13:09
@ManuGowda ManuGowda merged commit ae57049 into feature/4034-change-sdk-api Dec 1, 2022
@ManuGowda ManuGowda deleted the checkbox-should-not-look-like-radio-button branch December 1, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants