Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dpos constants query hook - Closes #4502 #4541

Merged

Conversation

eniolam1000752
Copy link
Contributor

What was the problem?

This PR resolves #4502

How was it solved?

  • Implement useDposConstants query hook
  • implement MSW handler for the dpos constants query
  • implement unit tests for useDposConstants
  • replace dposTokenId with actual api call using useDposConstants query hook
  • fix filling unit tests.

How was it tested?

visually
jest

@eniolam1000752 eniolam1000752 self-assigned this Oct 26, 2022

jest.mock('@token/fungible/hooks/queries');
jest.mock('../../hooks/queries');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eniolam1000752 Avoid mocking entire folders to prevent unexpected issues

@soroushm soroushm merged commit 9a83940 into feature/4034-change-sdk-api Oct 26, 2022
@soroushm soroushm deleted the 4502-implement-dpos-constants-hook branch October 26, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants