Fix invalid URL - Closes #3887 #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
reviewed
Jan 11, 2022
Comment on lines
25
to
33
| const removeTrailingSlash = (input) => { | ||
| const bypassStrings = ['http:/', 'http://', 'https:/', 'https://']; | ||
|
|
||
| if (input.charAt(input.length - 1) !== '/' || bypassStrings.includes(input)) { | ||
| return input; | ||
| } | ||
|
|
||
| return input.substring(0, input.length - 1); | ||
| }; |
There was a problem hiding this comment.
Why not use a regex?
Suggested change
| const removeTrailingSlash = (input) => { | |
| const bypassStrings = ['http:/', 'http://', 'https:/', 'https://']; | |
| if (input.charAt(input.length - 1) !== '/' || bypassStrings.includes(input)) { | |
| return input; | |
| } | |
| return input.substring(0, input.length - 1); | |
| }; | |
| /** | |
| * Removes the trailing slash | |
| * | |
| * @param {string} url - A URL that might end in a slash | |
| * @returns {string} A URL without a trailing slash | |
| */ | |
| const removeTrailingSlash = url => url.replace(/\/$/, ''); |
reyraa
approved these changes
Jan 11, 2022
isalga
force-pushed
the
3887-fix-url-trailing-slash
branch
from
359ef28 to
8d814e3
Compare
reyraa
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Remove * Create removeTrailingSlash function * Use regex and add documentation * Only setAddress for last input Co-authored-by: Manu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #3887
How was it solved?
How was it tested?
Manually