Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unlock transaction transformers - Closes #3492, #3493, #3476 #3494

Merged
merged 8 commits into from
Apr 21, 2021

Conversation

UsamaHameed
Copy link
Contributor

@UsamaHameed UsamaHameed commented Apr 20, 2021

What was the problem?

This PR resolves #3492, #3493, #3476

How was it solved?

  • Properly convert transactions for unlock
  • Properly extract public key for accounts that are uninitialized

How was it tested?

Unit + Manually

@UsamaHameed UsamaHameed requested review from reyraa and isalga April 20, 2021 09:25
@UsamaHameed UsamaHameed self-assigned this Apr 20, 2021
isalga
isalga previously approved these changes Apr 20, 2021
src/utils/api/account/lsk.js Outdated Show resolved Hide resolved
src/utils/api/account/lsk.js Outdated Show resolved Hide resolved
src/utils/api/account/lsk.js Show resolved Hide resolved
@UsamaHameed UsamaHameed changed the title Fix unlock transaction transformers - Closes #3492, #3493 Fix unlock transaction transformers - Closes #3492, #3493, #3476 Apr 21, 2021
@UsamaHameed UsamaHameed requested review from reyraa and isalga April 21, 2021 09:21
@UsamaHameed UsamaHameed merged commit 2d73fff into development Apr 21, 2021
@UsamaHameed UsamaHameed deleted the 3493-fix-unlock-tx branch April 21, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix transactions for uninitialized accounts
3 participants