Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data size to the details of a single transaction - Closes #2514 #2686

Merged
merged 12 commits into from
Dec 6, 2019
Merged

Add data size to the details of a single transaction - Closes #2514 #2686

merged 12 commits into from
Dec 6, 2019

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Dec 3, 2019

What issue have I solved?

Resolves #2514

How have I implemented/fixed it?

  • Added the data size next to message
    Extra: Removed the steps label in registration process since designers complained about it :-)

Review checklist

@reyraa reyraa requested a review from yasharAyari December 3, 2019 16:34
@reyraa reyraa self-assigned this Dec 3, 2019
@reyraa reyraa requested review from colado and removed request for yasharAyari December 5, 2019 10:07
slaweet
slaweet suggested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🎨 Font size of message changed from 15px to 13px

src/components/screens/explorer/transactions/transactionDetailView/transactionDetailView.js Outdated Show resolved Hide resolved
src/utils/helpers.js Outdated Show resolved Hide resolved
src/utils/helpers.js Outdated Show resolved Hide resolved
@reyraa reyraa requested a review from slaweet December 6, 2019 15:07
slaweet
slaweet suggested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one bug

src/utils/helpers.js Outdated Show resolved Hide resolved
slaweet
slaweet approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thank you, Ali.

@slaweet slaweet merged commit ca59c3b into development Dec 6, 2019
@slaweet slaweet deleted the 2514-data-size branch December 6, 2019 17:17
@slaweet slaweet removed the request for review from colado December 6, 2019 17:17
@slaweet slaweet mentioned this pull request Dec 11, 2019
Closed
@slaweet slaweet mentioned this pull request Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@reyraa reyraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data size to the details of a single transaction
2 participants
@reyraa @slaweet