Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable signMessage e2e tests - Closes #1019 #1021

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Enable signMessage e2e tests - Closes #1019 #1021

merged 2 commits into from
Jul 11, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Jul 11, 2018 •
edited
Loading

What was the problem?

  • signMessage e2e tests were not enabled

How did I fix it?

  • enabling them, and updating e2e asserting the output is valid

How to test it?

Review checklist

@faival faival self-assigned this Jul 11, 2018
@faival faival requested a review from slaweet July 11, 2018 14:15
@faival faival changed the title Enable signMessage e2e tests - Close #1019 Enable signMessage e2e tests - Closes #1019 Jul 11, 2018
slaweet
slaweet approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Pablo

@faival faival merged commit ffd2058 into 1.0.0 Jul 11, 2018
@faival faival deleted the 1019-sign-message-feature-should-pass-e2e-core-1.0.0-migration branch July 11, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@faival faival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faival @slaweet