Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application fails to load modules defined in lisk-api-client #4520

Closed
Tracked by #4341
soroushm opened this issue Oct 20, 2022 · 1 comment
Closed
Tracked by #4341

Application fails to load modules defined in lisk-api-client #4520

soroushm opened this issue Oct 20, 2022 · 1 comment
Assignees
@soroushm
Labels
priority: high type: bug unplanned
Milestone
Sprint 86

Comments

@soroushm
Copy link
Contributor

soroushm commented Oct 20, 2022 •
edited
Loading

Expected behavior

after @liskhq/lisk-client released version 6.0.0-alpha.32064 wallet desktop complain about some of the packages is not exist in web browser, web-pack/babel should use browser export instead of node version

Actual behavior

index.js:6 Uncaught ReferenceError: require is not defined
    at ./node_modules/node-gyp-build/index.js (index.js:6:22)
    at __webpack_require__ (bootstrap:21:1)
    at fn (hot module replacement:61:1)
    at ./node_modules/zeromq/lib/native.js (native.js:6:18)
    at __webpack_require__ (bootstrap:21:1)
    at fn (hot module replacement:61:1)
    at ./node_modules/zeromq/lib/index.js (index.js:3:16)
    at __webpack_require__ (bootstrap:21:1)
    at fn (hot module replacement:61:1)
    at ./node_modules/@liskhq/lisk-api-client/dist-node/ipc_channel.js (ipc_channel.js:7:18)

Steps to reproduce

NPM install latest version of SDK

Which version(s) does this affect? (Environment, OS, etc...)

Version 3.0.0
@ManuGowda ManuGowda changed the title require is not defined, lisk-api-client Application fails to load modules defined in lisk-api-client Oct 20, 2022
@soroushm soroushm self-assigned this Oct 21, 2022
soroushm added a commit that referenced this issue Oct 24, 2022
@soroushm
fix: lisk-client issue #4520
b907e98
@soroushm soroushm mentioned this issue Oct 25, 2022
Merged
@sridharmeganathan sridharmeganathan added this to the Sprint 86 milestone Oct 25, 2022
soroushm added a commit that referenced this issue Oct 31, 2022
@soroushm
fix: lisk-client issue #4520
52add0d
soroushm pushed a commit that referenced this issue Nov 1, 2022
Merge pull request #4540 from LiskHQ/4520-lisk-client-throw-error
af00c6c 
Fix for lisk-client Require undefined issues  - Closes #4520
@soroushm
Copy link
Contributor Author

soroushm commented Nov 1, 2022

We used patch-package to fix the package for now but its need fix from the package

@soroushm soroushm closed this as completed Nov 1, 2022
Repository owner moved this from Backlog to Done in Lisk Desktop Version 3.0.0 Nov 1, 2022
@sridharmeganathan sridharmeganathan mentioned this issue Nov 8, 2022
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soroushm soroushm

Labels
priority: high type: bug unplanned
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 86
Development

No branches or pull requests
2 participants
@soroushm @sridharmeganathan