Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage of actions files #3930

Closed
Tracked by #3699
reyraa opened this issue Nov 15, 2021 · 0 comments · Fixed by #3931
Closed
Tracked by #3699

Increase test coverage of actions files #3930

reyraa opened this issue Nov 15, 2021 · 0 comments · Fixed by #3931
Assignees
@isalga
Labels
type: task type: test
Milestone
Sprint 65

Comments

@reyraa
Copy link
Contributor

reyraa commented Nov 15, 2021 •
edited
Loading

Description

We've temporarily skipped the missing test coverage of actions files in order to implement #3836 with higher priority. We should implement the missing test coverage once #3836 is done.

Acceptance Criteria

In the actions directory:

  • The test coverage should surpass the 80% threshold.
  • The Istanbul signore comments must be removed.
  • Actions files listed in the coveragePathIgnorePatterns in jestConfig file must be removed.
This was referenced Nov 15, 2021
Merged
Merged
@sridharmeganathan sridharmeganathan added this to the Sprint 62 milestone Nov 17, 2021
@sridharmeganathan sridharmeganathan mentioned this issue Nov 23, 2021
Closed
11 tasks
@ManuGowda ManuGowda assigned ikem-legend and unassigned ManuGowda Nov 24, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 63 milestone Dec 8, 2021
@ManuGowda ManuGowda added this to the Spike 3 milestone Dec 17, 2021
@ManuGowda ManuGowda modified the milestones: Spike 3, Sprint 65 Jan 1, 2022
@eniolam1000752 eniolam1000752 assigned isalga and unassigned ikem-legend Jan 3, 2022
@ManuGowda ManuGowda mentioned this issue Jan 4, 2022
Merged
ManuGowda added a commit that referenced this issue Jan 4, 2022
@ManuGowda
Merge pull request #4032 from LiskHQ/3930-increase-actions-test-coverage
aab3886 
Increase actions test coverage - Closes #3930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isalga isalga

Labels
type: task type: test
Projects
None yet
Milestone
Sprint 65
Development

Successfully merging a pull request may close this issue.

Add hardware wallet pending screen - Closes #3836 LiskHQ/lisk-desktop
5 participants
@reyraa @isalga @ManuGowda @ikem-legend @sridharmeganathan