Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate unit test coverage for files added to coverage ignore list #3773

Closed
reyraa opened this issue Sep 8, 2021 · 0 comments · Fixed by #3774
Closed

Reinstate unit test coverage for files added to coverage ignore list #3773

reyraa opened this issue Sep 8, 2021 · 0 comments · Fixed by #3774
Assignees
@ikem-legend
Labels
type: test
Milestone
Sprint 58

Comments

@reyraa
Copy link
Contributor

reyraa commented Sep 8, 2021 •
edited by ikem-legend
Loading

Description

The following files have been added to the coverage ignore list as a compromise to meet the deadlines. Since we have released v2.0.0, we'd like to increase the test coverage of the following files:

  • src/store/actions/settings.js
  • src/store/actions/transactions.js

Acceptance Criteria

  • All unit tests must meet the coverage threshold
  • All functions must be unit tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikem-legend ikem-legend

Labels
type: test
Projects
None yet
Milestone
Sprint 58
Development

Successfully merging a pull request may close this issue.

Fixed settings action test - Closes #3773 LiskHQ/lisk-desktop
3 participants
@reyraa @ikem-legend @sridharmeganathan