This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitetester
commented
Oct 4, 2023
...st/unit/modules/interoperability/mainchain/commands/terminate_sidechain_for_liveness.spec.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## release/6.1.0 #9063 +/- ##
=================================================
- Coverage 84.33% 84.33% -0.01%
=================================================
Files 652 652
Lines 23965 23960 -5
Branches 3487 3485 -2
=================================================
- Hits 20212 20207 -5
Misses 3753 3753
|
ishantiw
suggested changes
Oct 10, 2023
framework/src/modules/interoperability/mainchain/commands/terminate_sidechain_for_liveness.ts
Outdated
Show resolved
Hide resolved
...st/unit/modules/interoperability/mainchain/commands/terminate_sidechain_for_liveness.spec.ts
Outdated
Show resolved
Hide resolved
gkoumout
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, assuming the verification part is handled consistently with rest of SDK.
framework/src/modules/interoperability/mainchain/commands/terminate_sidechain_for_liveness.ts
Show resolved
Hide resolved
ishantiw
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8193
Regarding this point:
How was it solved?
validator.validate
check appliedHow was it tested?
Relevant test added