Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update terminate liveness command #9063

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

sitetester
Copy link
Contributor

@sitetester sitetester commented Oct 4, 2023

What was the problem?

This PR resolves #8193

Regarding this point:

Line 126: This test should be reverted. The verify() function throws error when the chain is Live; when it is not live, verification is successful. So, the description should be "should return error if the chain is live" and in line 127 call mockResolvedValue(true).

  • line 126: Test title is already updated
  • line 127: Already set
describe('verify', () => {
   ...
   beforeEach(async () => {
   ...
       jest.spyOn(interopMod['internalMethod'], 'isLive').mockResolvedValue(true);
       ...
   ....
   });
});

How was it solved?

  • Source code updated with latest code changes
  • validator.validate check applied

How was it tested?

Relevant test added

@sitetester sitetester changed the base branch from development to release/6.1.0 October 4, 2023 13:43
@sitetester sitetester self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #9063 (1e99a48) into release/6.1.0 (d75cf3a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 1e99a48 differs from pull request most recent head 50bca2f. Consider uploading reports for the commit 50bca2f to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.1.0    #9063      +/-   ##
=================================================
- Coverage          84.33%   84.33%   -0.01%     
=================================================
  Files                652      652              
  Lines              23965    23960       -5     
  Branches            3487     3485       -2     
=================================================
- Hits               20212    20207       -5     
  Misses              3753     3753              
Files Coverage Δ
...chain/commands/terminate_sidechain_for_liveness.ts 100.00% <100.00%> (ø)
framework/src/modules/interoperability/schemas.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link

@gkoumout gkoumout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming the verification part is handled consistently with rest of SDK.

@ishantiw ishantiw enabled auto-merge (squash) October 12, 2023 14:20
@ishantiw ishantiw merged commit bc36386 into release/6.1.0 Oct 12, 2023
@ishantiw ishantiw deleted the 8193-terminate-liveness-command branch October 12, 2023 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test Review: Interoperability commands
3 participants