This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobanm
force-pushed
the
8954-refactor-nft-transfers
branch
from
September 20, 2023 15:09
2671af6
to
6dc1c4b
Compare
Codecov Report
@@ Coverage Diff @@
## release/6.1.0 #9005 +/- ##
=================================================
- Coverage 84.36% 84.34% -0.02%
=================================================
Files 651 652 +1
Lines 23977 23972 -5
Branches 3488 3486 -2
=================================================
- Hits 20227 20220 -7
- Misses 3750 3752 +2
|
shuse2
suggested changes
Sep 21, 2023
mjerkov
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactorization, this part will have to be touched upon again when getNFT
is introduced, and getChainID
, getNFTOwner
, and getLockingModule
are removed.
shuse2
approved these changes
Sep 25, 2023
mjerkov
reviewed
Oct 6, 2023
shuse2
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8954, resolves #8986, partially resolves #8961 and resolves #9066
How was it solved?
How was it tested?
All the existing tests are passing.